-
Notifications
You must be signed in to change notification settings - Fork 99
feat: Add additional PR field in CheckRunResponse and CheckSuite #230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #230 +/- ##
============================================
- Coverage 77.41% 76.73% -0.68%
Complexity 433 433
============================================
Files 60 60
Lines 1368 1380 +12
Branches 60 60
============================================
Hits 1059 1059
- Misses 265 277 +12
Partials 44 44 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
a1b691f to
5170ff4
Compare
5170ff4 to
3ca45e5
Compare
dennisgranath
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
| @JsonDeserialize(as = ImmutablePartialPullRequestItem.class) | ||
| public interface PartialPullRequestItem extends CloseTracking { | ||
| /** ID. */ | ||
| Long id(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This introduced a breaking change because they were all optional.
| URI url(); | ||
|
|
||
| /** Number. */ | ||
| Long number(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This changes from Integer to Long, which is also a breaking change.
Changes:
pull_requestsfield to both CheckRunResponse and CheckSuite classPartialPullRequestItemwhich is usually part of thepull_requestsfield in check runs as they don't have the complete PR object.